fix: reset page.redirect_url before browsing to prevent false errors …#441
Merged
adam-miller merged 4 commits intomasterfrom Jan 21, 2026
Merged
Conversation
mistydemeo
approved these changes
Jan 17, 2026
Contributor
|
Something a little weird happened in the tests; may need to rerun them. |
alindeman
approved these changes
Jan 20, 2026
alindeman
left a comment
alindeman
left a comment
There was a problem hiding this comment.
LGTM overall. I left one thought, but consider it optional and non-blocking.
| window_width=self._window_width, | ||
| headless=self._headless, | ||
| ) | ||
| page.redirect_url = None |
There was a problem hiding this comment.
I wonder if this makes sense as a method on Page, like note_redirect is (clear_redirect or similar?). Alternatively, maybe note_redirect could be removed and the one call site below changed to page.redirect_url = ... if we're comfortable manipulating redirect_url directly.
Contributor
Author
There was a problem hiding this comment.
Changed it to clear_redirect(). That helps make it a little more clear why the value is being reset.
adam-miller
added a commit
that referenced
this pull request
Jan 21, 2026
#441) * fix: reset page.redirect_url before browsing to prevent false errors in retry loops * chore: formatting unit test * chore: more formatting * chore: refactor reset of page.redirect_url
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in retry loops